[FIX] Credentials: handling password credentials error #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernc
reviewed
May 30, 2017
Orange/widgets/credentials.py
Outdated
| try: | ||
| return keyring.get_password(self.service_name, item) | ||
| except Exception: | ||
| return "" |
There was a problem hiding this comment.
Shouldn't we default to None as is returned when the key is not yet set?
>>> import keyring
>>> print(keyring.get_password('Orange3 - random test', 'nonexistent key')
None| @@ -32,7 +32,10 @@ def __setattr__(self, key, value): | |||
| keyring.set_password(self.service_name, key, value) | |||
There was a problem hiding this comment.
Can the setter also raise e.g. if the keyring isn't unlocked?
Codecov Report
@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 73.37% 73.35% -0.03%
==========================================
Files 317 317
Lines 55570 55615 +45
==========================================
+ Hits 40777 40797 +20
- Misses 14793 14818 +25 |
kernc
reviewed
May 30, 2017
Orange/widgets/credentials.py
Outdated
| except Exception: | ||
| log.error("Failed to get password for '{}'.".format(self.service_name), | ||
| exc_info=True) | ||
| return None | ||
|
|
||
| def __delattr__(self, item): | ||
| keyring.delete_password(self.service_name, item) |
There was a problem hiding this comment.
Can the deleter, then, also raise?
There was a problem hiding this comment.
Yes, sure it can. For instance:
# keyring.errors.PasswordDeleteError: No such password!
# RuntimeError:
3 tasks
nikicc
suggested changes
May 31, 2017
There was a problem hiding this comment.
Can you catch more specific exceptions? PasswordSetError and PasswordDeleteError from https://github.com/jaraco/keyring/blob/master/keyring/errors.py#L3 should do the trick.
jerneju
changed the title
nikicc
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
biolab/orange3-text#253
Description of changes
try except block
Includes