Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] WebEngineView: Insert JS if loading already started #2230

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

nikicc
Copy link
Contributor

@nikicc nikicc commented Apr 12, 2017

Issue

When loading schemas with widgets that extend Orange.widgets.highcharts.Highchart Orange sometimes hangs with JS error:

js: Uncaught ReferenceError: fixupPythonObject is not defined
Description of changes

WebEngineView._onloadJS also calls self.page().scripts().insert(script) and not just connects it to self.loadStarted. In case that loading has already started (e.g. if WebEngineView receives QUrl among parameters to init) connecting of self.loadStarted occurs too late.

Includes
  • Code changes
  • Tests
  • Documentation

If WebEngineView recieved QUrl among paramters to __init__, loading can start before we connect JS inseration with self.loadStarted.connect.
@codecov-io
Copy link

Codecov Report

Merging #2230 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2230      +/-   ##
==========================================
+ Coverage   72.17%   72.17%   +<.01%     
==========================================
  Files         318      318              
  Lines       54773    54774       +1     
==========================================
+ Hits        39533    39534       +1     
  Misses      15240    15240

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568cefb...16fc00a. Read the comment docs.

@kernc kernc added this to the 3.4.2 milestone Apr 14, 2017
@astaric astaric modified the milestones: 3.4.2, future Apr 19, 2017
@astaric astaric merged commit e63c72b into biolab:master Apr 21, 2017
@nikicc nikicc deleted the webengine-loading-error branch April 21, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants