[FIX] WebEngineView: Insert JS if loading already started #2230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When loading schemas with widgets that extend
Orange.widgets.highcharts.Highchart
Orange sometimes hangs with JS error:Description of changes
WebEngineView._onloadJS
also callsself.page().scripts().insert(script)
and not just connects it toself.loadStarted
. In case that loading has already started (e.g. if WebEngineView receives QUrl among parameters to init) connecting ofself.loadStarted
occurs too late.Includes