-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] OWTestLearners: Cross validation by feature #2145
Conversation
bb4c530
to
e5edb48
Compare
Codecov Report
@@ Coverage Diff @@
## master #2145 +/- ##
=========================================
Coverage ? 72.08%
=========================================
Files ? 318
Lines ? 54653
Branches ? 0
=========================================
Hits ? 39397
Misses ? 15256
Partials ? 0 Continue to review full report at Codecov.
|
a9c5b5c
to
a2802d6
Compare
a2802d6
to
e12109d
Compare
I know this will come as a totally unusual surprise, but I'm disapproving the GUI. :) The feature, if I read the code correctly, doesn't determine the number of folds, but the folds themselves. This looks like a useful feature, but I wouldn't expect it in cross-validation, and particularly not in the "Number of folds" combo. "From feature" also doesn't fit into an unexpanded combo. The "from feature" option fundamentally changes the sampling procedure in the sense that it is no longer random. As a minor argument against this GUI, we also discourage show/hide, and prefer enabling/disabling instead, where this could be sensibly avoided. One solution would be to add a new radio button "Cross validation by feature" below "Cross validation". With this, this functionality would be more prominent and we'd no longer need hiding/showing of parts of the interface. The radio button can be disable if there are no meta attributes. If you do this, don't forget to provide appropriate migration of settings. |
The main functionality is not tested (the corresponding radio button is never clicked). :) When cross validation by feature is used for a file, which is then disconnected and connected back, the setting are reset. |
Issue
Add type of CV where number of feature values determines number of folds.
Use only discrete meta features.
Description of changes
Add radio button option to select this type of CV.
Add combo box to select feature to give nr. of folds.
Documentation comes when gui is approved.
Includes