Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] OWKMeans: Auto-commit fix and silhuette optimization #2073

Merged
merged 2 commits into from
Mar 3, 2017
Merged

[FIX] OWKMeans: Auto-commit fix and silhuette optimization #2073

merged 2 commits into from
Mar 3, 2017

Conversation

thocevar
Copy link
Contributor

@thocevar thocevar commented Mar 3, 2017

Issue
  • widget crashes with a memory error on large datasets (e.g., adult)
  • auto-commit doesn't work (disabling it has no effect)
Description of changes
  • compute silhuette score on a sample of at most 5000 instances
  • remove connections of apply() before calling auto_commit
Includes
  • Code changes
  • Tests
  • Documentation

@lanzagar lanzagar self-assigned this Mar 3, 2017
@lanzagar lanzagar changed the title [FIX] OWKMeans [FIX] OWKMeans: Auto-commit fix and silhuette optimization Mar 3, 2017
@lanzagar lanzagar merged commit f025f83 into biolab:master Mar 3, 2017
@markotoplak markotoplak mentioned this pull request Mar 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lanzagar lanzagar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thocevar @lanzagar