Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Heatmap: Fix crash on data with empty columns #2057

Merged
merged 1 commit into from
Mar 6, 2017
Merged

[FIX] Heatmap: Fix crash on data with empty columns #2057

merged 1 commit into from
Mar 6, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Feb 28, 2017

Issue

Invalid number of variable columns
Columns in a domain and in a table do not match.
https://sentry.io/biolab/orange3/issues/196744285/

Description of changes

If a column in a table is dropped, it is erased in a domain as well.

Includes
  • Code changes
  • Tests
  • Documentation

@jerneju
Copy link
Contributor Author

jerneju commented Feb 28, 2017

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@34b5e94). Click here to learn what that means.
The diff coverage is 88.88%.

@@           Coverage Diff            @@
##             master   #2057   +/-   ##
========================================
  Coverage          ?   70.7%           
========================================
  Files             ?     315           
  Lines             ?   53905           
  Branches          ?       0           
========================================
  Hits              ?   38114           
  Misses            ?   15791           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b5e94...fb3248d. Read the comment docs.

@jerneju
Copy link
Contributor Author

jerneju commented Mar 1, 2017

@astaric astaric changed the title [FIX] Valueerror - Invalid number of variable columns [FIX] Heatmap: Fix crash on data with empty columns Mar 3, 2017
@lanzagar lanzagar self-assigned this Mar 3, 2017
Invalid number of variable columns
Columns in a domain and in a table do not match.
https://sentry.io/biolab/orange3/issues/196744285/

If a column in a table is dropped, it is erased in a domain as well.
@lanzagar lanzagar merged commit 3eda749 into biolab:master Mar 6, 2017
@janezd
Copy link
Contributor

janezd commented Mar 6, 2017

@jerneju, as a general comment: this PR contains a fix and a test, and some code reformatting. Try keeping these changes in separate commits so they are easier to review. That is, put the reformatting into a separate commit.

(My pull requests may not be, or at least haven't been in the past, the best examples to follow, though. :)

@jerneju jerneju deleted the valueerror-owheatmap branch April 20, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants