[FIX] OWSave: Safer Check if Writer Support Sparse #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access SUPPORT_SPARSE_DATA in a safer manner to prevent chrashes if flag is not set for some writter; like in writers from addons.
Current coverage is 89.25% (diff: 100%)@@ master #1864 diff @@
==========================================
Files 86 86
Lines 9100 9100
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 8122 8122
Misses 978 978
Partials 0 0
|
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 6, 2017
[FIX] OWSave: Safer Check if Writer Support Sparse (cherry picked from commit 7acb5fc)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 10, 2017
[FIX] OWSave: Safer Check if Writer Support Sparse (cherry picked from commit 7acb5fc)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 11, 2017
[FIX] OWSave: Safer Check if Writer Support Sparse (cherry picked from commit 7acb5fc)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 13, 2017
[FIX] OWSave: Safer Check if Writer Support Sparse (cherry picked from commit 7acb5fc)
astaric
pushed a commit
to astaric/orange3
that referenced
this pull request
Jan 18, 2017
[FIX] OWSave: Safer Check if Writer Support Sparse (cherry picked from commit 7acb5fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Some writers in addons did not have
SUPPORT_SPARSE_DATAflag which causedOWSaveto crash.Description of changes
Check if writer supports sparse more safely; i.e. if there is no flag assume it does not support sparse.
Includes