Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owrank: Add migrate_settings #1797

Merged
merged 1 commit into from
Dec 2, 2016

Conversation

ales-erjavec
Copy link
Contributor

Issue

ref #1794

Fix an error when restoring from a workflow that was saved before widget supported ranking features on data with no class.

Traceback (most recent call last):
  File "/Users/aleserjavec/workspace/orange3/Orange/canvas/scheme/widgetsscheme.py", line 454, in create_widget_instance
    widget.__init__()
  File "/Users/aleserjavec/workspace/orange3/Orange/widgets/data/owrank.py", line 260, in __init__
    if self.headerState[2] is not None:
IndexError: tuple index out of range
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

Fix an error when restoring from a workflow that was saved before
widget supported ranking features on data with no class.
@codecov-io
Copy link

codecov-io commented Dec 2, 2016

Current coverage is 88.96% (diff: 100%)

Merging #1797 into master will not change coverage

@@             master      #1797   diff @@
==========================================
  Files            82         82          
  Lines          8963       8963          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7974       7974          
  Misses          989        989          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 11c3f11...fb6bc5b

@janezd janezd merged commit 17a564a into biolab:master Dec 2, 2016
@ales-erjavec ales-erjavec deleted the fixes/rank-migrate-settings branch January 9, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants