Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Extend widget creation policy #1611

Merged
merged 5 commits into from
Sep 30, 2016

Conversation

ales-erjavec
Copy link
Contributor

  • Extend widget creation policy so widgets can be created only on
    demand. This makes it possible to open/edit workflow without any
    OWWidget instances being created until they are activated (opened/double
    clicked). This policy is active when the stop signal propagation action is checked
    in the canvas (Pause/Play button in the bottom toolbar)
  • Better guard against explicit event loop reentry from OWWidget's __init__

* Better guard against explicit event loop reentry from widget's `__init__`
* Extend widget creation policy so all widgets are created only on
  demand. This makes it possible to open/edit workflow without any
  OWWidget instances being created until they are activated (opened/double
  clicked)
Process pending nodes in FIFO order
@codecov-io
Copy link

codecov-io commented Sep 27, 2016

Current coverage is 88.67% (diff: 100%)

Merging #1611 into master will not change coverage

@@             master      #1611   diff @@
==========================================
  Files            78         78          
  Lines          8134       8134          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           7213       7213          
  Misses          921        921          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update d848f01...11c18b4

@janezd janezd merged commit 6b15074 into biolab:master Sep 30, 2016
@ales-erjavec ales-erjavec deleted the widget-creation-policy branch September 30, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants