Rank widget computes scores when domain has no class variable, provided a Scorer. #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided a Scorer (e.g PCA).
Current coverage is 88.86% (diff: 100%)@@ master #1566 diff @@
==========================================
Files 78 78
Lines 8099 8099
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7197 7197
Misses 902 902
Partials 0 0
|
|
Works only if the widget gets the scorer after receiving the data. Even if the scorer comes later, the error re-appears when the data is reloaded. I'm closing the PR because a fix in this fashion can't work and because #1560 turned the widget upside down anyway, so this PR is no longer applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error reporting has been modified accordingly.
Fixes #1556