[FIX] owimageviewer: Open local images directly

[ales-erjavec]

Using QNetworkAccessManager to 'retrieve' many local files can lead
to temporarily running out of available file descriptors.

Presumably this is because the associated open fd is not closed
until the QNetworkReply is actually deleted (and not just closed).

[codecov-io]

Current coverage is 88.28% (diff: 100%)

Merging #1550 into master will not change coverage

@@             master      #1550   diff @@
==========================================
  Files            77         77          
  Lines          7629       7629          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           6735       6735          
  Misses          894        894          
  Partials          0          0          

Powered by Codecov. Last update d793eaf...1dd7873

[astaric]

I cannot reproduce the original problem on my machine. @BlazZupan, can you check if this solves the issue for you?

[ales-erjavec]

I cannot reproduce the original problem on my machine. @BlazZupan, can you check if this solves the issue for you?

Try running orange-canvas like so:

(ulimit -n 150; orange-canvas;)

(adjusting the limit appropriately to trigger the error)

[janezd]

Perhaps related: trying to view the images from https://www5.cs.fau.de/fileadmin/research/datasets/fundus-images/all.zip in the Image Viewer on Windows shows the first 20 or so out of 45 images and then complains that it cannot open the file.

I've seen this on somebody's computer, but cannot replicate it neither on Mac nor on Windows.

[BlazZupan]

Works fine on Mac. Should be checked on Win.

[astaric]

I am merging this. Testing on windows can be done with daily builds, when they become available.