[FIX] OWBaseLearner: Learner name is changed on output when user changes it and auto apply selected #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.91%@@ master #1453 diff @@
==========================================
Files 77 77
Lines 7582 7582
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6666 6666
Misses 916 916
Partials 0 0
|
|
Now it sends a new output after every key press. This can make it really slow when connected to e.g. Test&Score. |
|
@lanzagar I changed it that now apply happens only on focus-out. One thing that I do not like too much is button that shows that field is updated but not applied. It is part of gui script. |
|
It might be acceptable if the button appeared to the right of the text field. |
|
It has been fixed |
|
Looks good to me now. |
…d auto apply checked.
PrimozGodec
force-pushed
the
base_learner
branch
from
6bfd2f6
to
1008ae0
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learner name field didn't have callback when it is changed. Problem was when user changed name and auto apply was on, because name haven't changed on output. It is fixed with this PR.