[FIX] SqlTable: Cast to text for unknown and string types #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.94%@@ master #1430 diff @@
==========================================
Files 77 77
Lines 7582 7580 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6671 6666 -5
- Misses 911 914 +3
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown SQL field types are mapped to Orange StringVariables.
Before, if they were e.g. used in filters they could be compared to string constants etc. which might not be supported for that type.
Now if we read the data into StringVariables, cast them to text type first in the database.