[FIX] overlay: Auto disconnect when the overlay widget is deleted #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is misbehaving again and did not automatically run the tests. Could you rebase and push again please? |
Register `__on_destroyed` as a Qt slot so it can be automatically disconnected when the overlay widget is deleted/destroyed. This fixes a possible 'RuntimeError C/C++ object was deleted ...' error when the overlay is deleted before the target widget.
Current coverage is 87.95%@@ master #1412 diff @@
==========================================
Files 77 77
Lines 7561 7561
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6650 6650
Misses 911 911
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register
__on_destroyedas a Qt slot so it can be automaticallydisconnected when the overlay widget is deleted/destroyed.
This fixes a possible 'RuntimeError C/C++ object was deleted ...' error
when the overlay is deleted before the target widget.