Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_filename_dialog: Allow reading *.* #278

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Sep 19, 2024

Issue

open_filename_dialog has an argument add_all which, if True, adds "All readable files" that allows loading a file with any known extension. This is not enough to implement biolab/orange3#6792.

Description of changes
  • If add_all is set to * it offers all extensions (.), not just the known.
  • An unrelated improvement: if there is only a single file format, "All readable files" makes no sense and is not shown. This is situation might be common - there may be only a single file format and the caller forgets to change the default value of add_all from True to False.
  • Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.79%. Comparing base (9ae212f) to head (7c6f189).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files          34       34           
  Lines        9114     9117    +3     
=======================================
+ Hits         6543     6546    +3     
  Misses       2571     2571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd force-pushed the open_filename_dialog-all-files branch from 07a2b29 to 511f4be Compare September 19, 2024 18:08
@markotoplak markotoplak merged commit f84655f into biolab:master Sep 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants