feat(checkout): CHECKOUT-8824 Add Consignment Not Completed Message #2099
+116
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-peng
force-pushed
the
CHECKOUT-8824-ALERT
branch
from
7b2d398
to
7ffab31
Compare
bc-peng
commented
Nov 14, 2024
Comment on lines
+73
to
+75
| const errorConsignmentIndex = consignments.findIndex( | ||
| (consignment) => !consignment.selectedShippingOption, | ||
| ); |
There was a problem hiding this comment.
Due to the inconsistency of the consignment order, it is better to find the index each time to locate the unfinished consignment.
bc-mackxu
approved these changes
Nov 14, 2024
| setIsAddShippingDestination(true); | ||
| } | ||
| if ( | ||
| consignments.length > 0 && |
There was a problem hiding this comment.
🍹 It appears redundant because it has already checked in hasSelectedShippingOptions
Suggested change
| consignments.length > 0 && |
| @@ -510,6 +510,7 @@ | |||
| "select_shipping_address_text": "Please select a shipping address in order to see shipping quotes", | |||
| "shipping_address_heading": "Shipping Address", | |||
| "multishipping_consignment_index_heading": "Destination #{consignmentNumber}", | |||
| "multishipping_consignment_not_completed_error": "Please complete the address, item allocation, and method selection for Destination #{consignmentNumber}.", | |||
There was a problem hiding this comment.
🍹
Suggested change
| "multishipping_consignment_not_completed_error": "Please complete the address, item allocation, and method selection for Destination #{consignmentNumber}.", | |
| "multishipping_incomplete_consignment_error": "Please complete the address, item allocation, and method selection for Destination #{consignmentNumber}.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Show a message when a shopper is trying to create another one but an existing consignment is not finished yet.
Also, hide the message when the previous consignment is done.
Why?
Improve UX.
Testing / Proof
Show the error message when adding a new consignment is not finsihed
Screen.Recording.2024-11-14.at.11.55.29.AM.mov
Show the error message when an existing consignment is not finsihed
Screen.Recording.2024-11-14.at.11.55.04.AM.mov
Hide the error message after selecting shipping method
Screen.Recording.2024-11-14.at.11.53.14.AM.mov
Hide the error message after consignment deletion
Screen.Recording.2024-11-14.at.11.53.39.AM.mov
@bigcommerce/team-checkout