feat(payment): PAYPAL-4827 Fixed Paypal Fastlane bug when edit card and return back to checkout page #2098
+350
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4827
branch
13 times, most recently
from
3ee5e87
to
dc9fece
Compare
|
Can you add a video recording before the fix, please? |
Added |
andriiVitvitskyi1990
changed the title
bc-nick
reviewed
Nov 14, 2024
bc-nick
reviewed
Nov 14, 2024
| @@ -1,5 +1,5 @@ | |||
| import { CheckoutService, createCheckoutService } from '@bigcommerce/checkout-sdk'; | |||
| import { mount, ReactWrapper, shallow } from 'enzyme'; | |||
| import { mount, ReactWrapper } from 'enzyme'; | |||
There was a problem hiding this comment.
As far as I know we have to update tests with switching to @testing-library if we make any changes (maybe not any, but when we add a new test, for sure) in oldest one. Because there is no reason to support the old approach if we need to move to a new one.
There was a problem hiding this comment.
I just removed 'shallow' because it wasn't used anywhere
There was a problem hiding this comment.
My new added test doesn't use any specified to enzyme or rts methods
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4827
branch
3 times, most recently
from
da88434
to
68aa4ee
Compare
bc-nick
reviewed
Nov 15, 2024
packages/core/src/app/shipping/PayPalFastlaneShippingAddress.test.tsx
Outdated
Show resolved
Hide resolved
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4827
branch
2 times, most recently
from
07ebbb7
to
ceed077
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4827
branch
from
ceed077
to
5d57641
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-4827
branch
from
5d57641
to
eff8dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed Paypal Fastlane bug when edit card and return back to checkout page
Why?
To fix unexpected behaviour
Testing / Proof
BEFORE
Screen.Recording.2024-11-14.at.13.35.19.mov
AFTER
https://github.com/user-attachments/assets/83d51566-5a56-4d1e-ae80-1dc1e7c43e7c
@bigcommerce/team-checkout