Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHECKOUT-8775: Toggle from multi shipping to single shipping and vice versa #2095

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

richapatel1510
Copy link
Contributor

What?

Handle actions when toggling from multi shipping to single shipping and vice versa

  1. When moving from single shipping to multi shipping in SF checkout
  • Delete the consignment so that multi shipping consignments can be freshly started.
  1. When moving from multi shipping to single shipping in SF checkout
  • Show the warning popup that all the consignments will be lost.

Why?

To improve the multi shipping user experience

Testing / Proof

  • CI checks
  • Manual testing
CHECKOUT-8775.mov

@bigcommerce/team-checkout

@richapatel1510 richapatel1510 requested a review from a team as a code owner November 7, 2024 06:25
@bc-mackxu
Copy link
Contributor

In the screen record 28 second, curiosity why the continue button went to top right screen?

image

@richapatel1510
Copy link
Contributor Author

That seems to be happening because its making multiple API calls to delete the consignment before moving back to single shipping, this doesn't happen when we only have 1 consignment in the multi shipping mode.

@bc-mackxu
Copy link
Contributor

@richapatel1510 It looks like a broken page to me, I think we should avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants