Cleanup the install script #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSpielinbox
reviewed
Jan 10, 2023
bbb-install.sh
Outdated
| @@ -111,6 +111,9 @@ main() { | |||
| LETS_ENCRYPT_OPTIONS="--webroot --non-interactive" | |||
| SOURCES_FETCHED=false | |||
|
|
|||
| # If grep'ing for a key in "apt-key list" is dangerous, should we find a better way to do it? | |||
There was a problem hiding this comment.
As apt-key is deprecated one should move to managing keys e.g. in /etc/apt/trusted.gpg.d/ entirely.
There was a problem hiding this comment.
@XSpielinbox is right. Since this is supposed to be a simple cleanup PR, I dropped the key management stuff completely. I'll put something better in a separate PR.
be a better way to decide if we want to stop it
instead of grep'ing for the package name in "dpkg -l" A problem with the grep'ing approach was that if a package was purged, it will still appear on "dpkg -l" and seem like it was installed.
… and bbb-install-2.6.sh
to find a better way of doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four commits - I don't think anything in here should be very controversial, so I packed them all together into one PR.