Fix MailCare Driver #114
Merged
Fix MailCare Driver #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Implemented in fork as well: https://packagist.org/packages/joelharkes/laravel-mailbox You could add additional content-type check to avoid the JSON messages (mistakenly setup) being seen as emails. |
joelharkes
reviewed
Mar 24, 2023
Comment on lines
11
to
14
| public function validator() | ||
| { | ||
| return Validator::make($this->all(), [ | ||
| 'email' => 'required', | ||
| ]); | ||
| return Validator::make($this->all(), []); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public function validator() | |
| { | |
| return Validator::make($this->all(), [ | |
| 'email' => 'required', | |
| ]); | |
| return Validator::make($this->all(), []); | |
| } | |
| public function rules() | |
| { | |
| return [ | |
| "content_type" => "required|in:message/rfc2822", | |
| ]; | |
| } | |
| public function prepareForValidation() | |
| { | |
| $this->merge([ | |
| "content_type" => $this->headers->get("Content-type"), | |
| ]); | |
| } |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The current implementation of the MailCare driver doesn't work.
This PR fix all the issues and has been fully tested. I also updated the doc.
Best regards,