Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed add_dependencies_to_description() #105

Closed
wants to merge 1 commit into from

Conversation

nevrome
Copy link
Collaborator

@nevrome nevrome commented Oct 20, 2019

I believe we can retire add_dependencies_to_description() now. The attachment package provides some solid functions that solve the underlying problem in a nice way.

The only thing missing there is an integration of the paper.Rmd file (and everything else outside of /R, /vignettes and /tests). But these paths can be added manually.

This PR is part of the #75 initiative.

@benmarwick
Copy link
Owner

Thanks for this, I wasn't aware of the 'attachment' package until you mentioned it in this PR. I've had a look at the package and tested it a bit. My opinion is that our add_dependencies_to_description() is more convenient and suitable for the compendium context. Our function requires no arguments, we run it once and it looks everywhere and updates the DESCRIPTION. With 'attachment' we have to think a bit more and do something like attachment::att_amend_desc(dir.r = "analysis/") (which doesn't do the same as add_dependencies_to_description() for me). Am I using 'attachment' incorrectly?

@nevrome nevrome closed this Dec 31, 2019
@nevrome nevrome deleted the retirement_dep_to_desc branch December 31, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants