Implement Pyroscope reporting #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? :) |
benfred
reviewed
Jun 2, 2023
There was a problem hiding this comment.
This might be more of a questions for @petethepig - but I'm wondering where this PR fits in with the pyroscope roadmap.
I saw that pyroscope was recently acquired by Grafana recently (congratulations on this btw!), and I'm wondering what the plans are moving forward for using py-spy with pyroscope. There used to be a pyroscope project https://github.com/pyroscope-io/py-spy for integration - but I see that project is now archived.
xtrime-ru
force-pushed
the
pyroscope_pr
branch
18 times, most recently
from
a8e6d36
to
b443050
Compare
xtrime-ru
force-pushed
the
pyroscope_pr
branch
5 times, most recently
from
7a438b3
to
ccfdc59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #554, implements Pyroscope reporting directly inside py-spy.