Separated minimums between design and simulate #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
The minimum primer length is set at 15, which is probably reasonable for designing new primers but is too restrictive for simulating given primers. The cited reference in code comment supports using 7, instead of 15.
This changes there to be a minimum for design (15, as existing code uses) and for simulate (7, as cited in paper). I also added an error for passing in short primers.
Why are you making these changes?
I would like to use simulate to test my own primers, but index errors are thrown if I use primers smaller than minimalPrimerLength
Are any changes breaking? (IMPORTANT)
The design code is unchanged. The simulate behavior changes because if someone simulated with short primers, the code would previously blow up with index error.
Pre-merge checklist
All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.
I actually do not see what linter is used (I've not written Go code before) - so please let me know what is appropriate here! Thanks!
primers/primers_test.go
for what this might look like.CHANGELOG.md
in the[Unreleased]
section.