Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Racon Conflict with Numeric Named Reads #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ad3002
Copy link

@ad3002 ad3002 commented Jan 22, 2024

This pull request addresses an open issue in Racon (isovic/racon#233), where Racon encounters an error if reads and contigs have identical names. In our project, we have read files with numeric names generated by an upstream tool, leading to a naming conflict in Racon.

To resolve this, I have implemented a solution where a 'unitig' prefix is added to unitig fasta records. This change effectively prevents the name conflict in Racon, and subsequent tests confirm that RNA-Bloom now operates as expected. This update ensures compatibility and stability in RNA-Bloom, addressing the named issue without affecting other functionalities.

Fix Racon crash by adding 'unitig' prefix to uni FASTA records with numeric names.
Resolve Racon Conflict with Numeric Named Reads
@kmnip
Copy link
Collaborator

kmnip commented Jan 23, 2024

Hi @ad3002 ,
Instead of modifying the code of RNA-Bloom, you can work around the issue by simply giving the read names a "proper" prefix (e.g. "seq"). You can do so easily with seqtk:

seqtk rename reads.fq seq > renamed_reads.fq

Ka Ming

@ad3002
Copy link
Author

ad3002 commented Jan 26, 2024

Yes, I did exactly that, another possible fix is to add this possible caveat to the RNA-Bloom documentation.
Because it crashes without any errors that can be linked to contig/rides matching. And without experience, it's impossible to find a solution.

@kmnip
Copy link
Collaborator

kmnip commented Jan 28, 2024

Thanks for the suggestion, I have added a note about it in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants