Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to indicate when google play integrity is not available #2251

Open
jleach opened this issue Oct 29, 2024 · 1 comment
Open

Add logging to indicate when google play integrity is not available #2251

jleach opened this issue Oct 29, 2024 · 1 comment

Comments

@jleach
Copy link
Member

jleach commented Oct 29, 2024

If Google Play integrity is not available on device log a message indicating this fact.

    const available = await isPlayIntegrityAvailable()
    if (!available) {
      return null
    }

For a stretch goal, all logging should make it easier to search through by including a key word like:

log.error(`${componentName}: Google Play Integrity is unavailable`)

Prints

AttestationService: Google Play integrity is unavailable
@cvarjao
Copy link
Member

cvarjao commented Oct 29, 2024

This seems to be important enough that should surface some sort of error message as opposed to silently fails, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants