Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DI for config in ModelsCommand #1242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wimski
Copy link
Contributor

@wimski wimski commented Aug 8, 2021

Summary

I've used dependency injection for the configuration class in order to avoid Laravel's magic. This makes the code more discoverable and will help refactoring down the line.

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Add a CHANGELOG.md entry

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@barryvdh 👍 from me!


Reminds me about #756 ; I still have non-Laravel code using this and it will break but a) no problem with that, I'll just adjust and it b) I think I'm the only one out there doing that anyway ;) [j/k but probably only a low number of ppl have to do this]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants