-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override secrets from path #204
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csatib02
requested review from
ramizpolic,
sagikazarmark and
akijakya
and removed request for
a team
July 30, 2024 11:53
csatib02
changed the base branch from
main
to
feat/secret-selection-done-on-provider-level
July 30, 2024 11:54
csatib02
changed the title
Feat/override secrets from path
fix: override secrets from path
Jul 30, 2024
csatib02
changed the base branch from
feat/secret-selection-done-on-provider-level
to
main
July 30, 2024 11:55
csatib02
changed the base branch from
main
to
feat/secret-selection-done-on-provider-level
July 30, 2024 12:16
csatib02
changed the base branch from
feat/secret-selection-done-on-provider-level
to
main
July 30, 2024 12:16
ramizpolic
requested changes
Aug 21, 2024
@ramizpolic |
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
csatib02
force-pushed
the
feat/override-secrets-from-path
branch
from
September 17, 2024 07:23
d3bd7f3
to
ec2935e
Compare
github-actions
bot
added
size/S
Denotes a PR that changes 10-99 lines
and removed
size/L
Denotes a PR that changes 500-999 lines
labels
Sep 17, 2024
ramizpolic
reviewed
Sep 17, 2024
ramizpolic
approved these changes
Sep 17, 2024
Signed-off-by: Bence Csati <[email protected]> chore: cr Signed-off-by: Bence Csati <[email protected]>
csatib02
force-pushed
the
feat/override-secrets-from-path
branch
from
September 17, 2024 10:44
fe8f53c
to
97a6852
Compare
github-actions
bot
added
size/M
Denotes a PR that changes 100-499 lines
and removed
size/S
Denotes a PR that changes 10-99 lines
labels
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #202
Notes for reviewers
Functionality is manually tested with the following script: