Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SOAP module spec #83

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Conversation

madhukaw
Copy link
Contributor

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (71705fa) 85.05% compared to head (c401e99) 85.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files           2        2           
  Lines          87       87           
  Branches       38       38           
=======================================
  Hits           74       74           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madhukaw madhukaw changed the title Update lang dependency to stable version Update SOAP module spec Aug 14, 2023
```

## 3. Supported SOAP Versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section has not been included into table-of-content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@madhukaw madhukaw requested a review from ayeshLK August 14, 2023 08:55
docs/spec/spec.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madhukaw madhukaw merged commit 20ea154 into ballerina-platform:master Aug 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants