Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer swap fee bounds #1054

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Safer swap fee bounds #1054

wants to merge 21 commits into from

Commits on Oct 15, 2024

  1. docs: clarity usage of MAX_FEE_PERCENTAGE

    @EndymionJkb
    EndymionJkb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    f5fa989 View commit details
    Browse the repository at this point in the history

  2. refactor: ensure static and dynamic fees cannot be exactly 100%

    @EndymionJkb
    EndymionJkb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    aaa1239 View commit details
    Browse the repository at this point in the history

  3. docs: comment possible divide-by-zero issue, and explain how it's avo… 

    …ided
    @EndymionJkb
    EndymionJkb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    bbe0e79 View commit details
    Browse the repository at this point in the history

  4. chore: update bytecode

    @EndymionJkb
    EndymionJkb committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    604eb2b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. refactor: set true minimum fee

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f066987 View commit details
    Browse the repository at this point in the history

  2. docs: clarify near 100% fees

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    1fbc828 View commit details
    Browse the repository at this point in the history

  3. refactor: restore ">" since MAX_FEE_PERCENTAGE is no longer 1e18 (sin… 

    …ce that's not really the maximum fee)
    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c52d2f8 View commit details
    Browse the repository at this point in the history

  4. test: update tests to reflect new MAX_FEE_PERCENTAGE

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bac774a View commit details
    Browse the repository at this point in the history

  5. chore: update bytecode

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a415455 View commit details
    Browse the repository at this point in the history

  6. duh: forgot to subtract 1

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f830640 View commit details
    Browse the repository at this point in the history

  7. test: adjust tests

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    595e882 View commit details
    Browse the repository at this point in the history

  8. chore: update bytecode

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2c6b07c View commit details
    Browse the repository at this point in the history

  9. docs: clarify comment

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    680c7bb View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into swap-fee-bounds

    @EndymionJkb
    EndymionJkb committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8003b79 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'main' into swap-fee-bounds

    @EndymionJkb
    EndymionJkb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    58fa522 View commit details
    Browse the repository at this point in the history

  2. chore: update gas

    @EndymionJkb
    EndymionJkb committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    64501c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge branch 'main' into swap-fee-bounds 

    # Conflicts:
#	pkg/pool-stable/test/gas/.hardhat-snapshots/[StablePool - Standard] add liquidity unbalanced - warm slots
#	pkg/pool-stable/test/gas/.hardhat-snapshots/[StablePool - With rate] remove liquidity single token exact out - warm slots
    @EndymionJkb
    EndymionJkb committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d68dc4f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Merge branch 'main' into swap-fee-bounds

    @EndymionJkb
    EndymionJkb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ebf3c07 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Merge branch 'main' into swap-fee-bounds

    @EndymionJkb
    EndymionJkb committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1acaac5 View commit details
    Browse the repository at this point in the history

  2. test: adjust to max pool creator fee

    @EndymionJkb
    EndymionJkb committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0db31dd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge branch 'main' into swap-fee-bounds 

    # Conflicts:
#	pkg/vault/test/.contract-sizes/VaultAdmin
    @EndymionJkb
    EndymionJkb committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2fbc233 View commit details
    Browse the repository at this point in the history