Merge pull request #32 from babbel/default-tags

Breaking change: Rename `var.tags` to `var.default_tags`
babbel · Sep 23, 2024 · 8f3152a · 8f3152a
2 parents c376965 + 976c879
commit 8f3152a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -14,11 +14,6 @@ module "secretsmanager-for-rollbar-access-tokens" {
   name_prefix = "example"
 
   rollbar_tokens = values(rollbar_project_access_token.example)
-
-  tags = {
-    app = "example"
-    env = "production"
-  }
 }
 ```
 

diff --git a/_test/main.tf b/_test/main.tf
@@ -22,7 +22,7 @@ module "secretsmanager" {
 
   rollbar_tokens = local.rollbar_tokens
 
-  tags = {
+  default_tags = {
     app = "example"
     env = "production"
   }

diff --git a/main.tf b/main.tf
@@ -2,7 +2,7 @@ resource "aws_secretsmanager_secret" "this" {
   name        = "${var.name_prefix}.rollbar_access_tokens"
   description = "Secret value is managed via Terraform"
 
-  tags = var.tags
+  tags = var.default_tags
 }
 
 resource "aws_secretsmanager_secret_version" "this" {

diff --git a/variables.tf b/variables.tf
@@ -1,3 +1,12 @@
+variable "default_tags" {
+  type    = map(string)
+  default = {}
+
+  description = <<EOS
+Map of tags assigned to all AWS resources created by this module.
+EOS
+}
+
 variable "name_prefix" {
   type = string
 
@@ -16,12 +25,3 @@ variable "rollbar_tokens" {
 List of objects having access tokens names and the token values which shall be loaded into the SecretsManager.
 EOS
 }
-
-variable "tags" {
-  type    = map(string)
-  default = {}
-
-  description = <<EOS
-Map of tags assigned to all AWS resources created by this module.
-EOS
-}