Warn when enabling socket_telemetry on unsupported platform #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenharman
force-pushed
the
handle_socket_telemetry_on_macos
branch
from
9e6a3cd
to
5746684
Compare
stevenharman
commented
May 13, 2024
Comment on lines
-126
to
+130
| expect(possible_lines.include?(line)).to eq(true) | ||
| expect(possible_lines).to include(line) |
There was a problem hiding this comment.
This will result in a more useful error message if the line doesn't match.
stevenharman
force-pushed
the
handle_socket_telemetry_on_macos
branch
from
5746684
to
04b2f10
Compare
|
Anyone opposed to this one? It's a nice experience improvement - certainly better than blowing up! |
The structs we depend on for collecting socket telemetry (`SOL_TCP` and `TCP_INFO`) don't exist on all platforms. In such cases, these constants won't be defined, and so we should WARN users and not enabled the `socket_telemetry` option. NOTE: On macOS, similar structs do exist: `Socket::IPPROTO_TCP` and `Socket::TCP_CONNECTION_INFO`, respectively, but I couldn't figure out the binary layout of the data, so couldn't unpack it. Maybe someone else knows more about those details and can dig in at some point.
stevenharman
force-pushed
the
handle_socket_telemetry_on_macos
branch
from
04b2f10
to
469ccaf
Compare
springerigor
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structs we depend on for collecting socket telemetry (
SOL_TCPandTCP_INFO) don't exist on all platforms. In such cases, these constants won't be defined, and so we should WARN users and not enabled thesocket_telemetryoption.NOTE: On macOS, similar structs do exist:
Socket::IPPROTO_TCPandSocket::TCP_CONNECTION_INFO, respectively, but I couldn't figure out the binary layout of the data, so couldn't unpack it. Maybe someone else knows more about those details and can dig in at some point.