Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/ts-support: Add new loader #19

Closed
wants to merge 2 commits into from

Conversation

ShadyMind
Copy link
Contributor

  • Move typescript dependency to regular dependency
  • Add typescript loader
  • Add test for typescript file

Astanin Boris added 2 commits October 22, 2022 10:39
* Move typescript dependency to regular dependency
* Add typescript loader
* Add test for typescript file
@azu
Copy link
Owner

azu commented Oct 22, 2022

Thanks for PR!

I think that TypeScript as config file is difficult.

  1. rc-config-loader does not provide your config type
  • It means that .ts support just compile the config file
  • It looks like useful, but I feel it is not complete
  • If pass the type check, but it may not filled config schema
  1. typescript package does not apply semantic versioning
    • It make difficult typescript as dependencies
  2. typescript is large and heavy

Summary: I feel it is an incomplete solution. On the other hand, maintenance costs will go up.
So, It is out of scope in current.

📝 We can resolve 2 and 3 by using peerDependencies, but it will be complex to use.
For example, webpack allow to use webpack.config.ts.

However, documentation is something wrong. I think this shows the complexity of TypeScript.

📝 I feel that a method like $scheme property of JSON Schema is a realistic solution.

Thanks for investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants