Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps version for examples and examples-web #154

Merged
merged 13 commits into from
Sep 19, 2023

Conversation

npty
Copy link
Member

@npty npty commented Sep 18, 2023

Description

Closes AXL-1880

  • Replaced axelar-cgp-solidity with axelar-chains-config to include only what we need.
  • Updated axelar-local-dev from 2.0.5 to 2.1.1
  • Updated axelar-gmp-sdk-solidity from 4.5.0 to 6.1.0

@npty npty changed the title Chore/update deps version chore: update deps version Sep 18, 2023
@npty npty self-assigned this Sep 18, 2023
@npty npty changed the title chore: update deps version chore: update deps version for examples and examples-web Sep 18, 2023
@npty npty marked this pull request as ready for review September 18, 2023 08:28
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about changing the Aptos default. Unless there's a strong reason, consider undoing that. Otherwise approved.

@@ -1,5 +1,5 @@
{
"aptos": {
"enabled": false
"enabled": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why re-enable this? Doesn't this add a bunch of extra dependencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It was accidentally pushed. i enabled it for testing purpose in my local.

@npty npty merged commit e3d5971 into main Sep 19, 2023
2 checks passed
@npty npty deleted the chore/update-deps-version branch September 19, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants