-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASH Running as non-root user #109
base: main
Are you sure you want to change the base?
ASH Running as non-root user #109
Conversation
…rtjh2/automated-security-helper into feature/78/run-container-non-root
…8/run-container-non-root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting one minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
…elines easier, reduce unnecessary complexity, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check 777 permission on /src and /out folders
This is better than where we started - so I'm good with merging. |
Includes changes from #79 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I understand the addition of --target
to the command-line options, since it is similar to the docker build
command-line option of --target
. However, in the context of the ash
command-line, I think it might cause some confusion.
Also, in the command-line help, it says image to build
- it probably should say image to run/build
.
Issue #, if available:
N/A
Description of changes:
Rebase from main with changes in #79 .
In this PR we made the following changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.