fix(integV2): remove unused protocol in well-known-endpoints

[jmayclin]

Description of changes:

This test queries each endpoint more than necessary.

The current test runs once for each protocol/cipher tuple. But the protocol has little effect on the security policy selection, so there are lots of duplicate test runs.

s2n-tls/tests/integrationv2/providers.py

Lines 243 to 251 in 53691f9

	# If the test provided a cipher (security policy) that is compatible with
	# s2n, we'll use it. Otherwise, default to the appropriate `test_all` policy.
	cipher_prefs = 'test_all_tls12'
	if self.options.protocol is Protocols.TLS13:
	cipher_prefs = 'test_all'
	if self.options.cipher and self.options.cipher.s2n:
	cipher_prefs = self.options.cipher.name
	cmd_line.extend(['-c', cipher_prefs])

E.g, all of the following tuples have the same exact configuration, because of the cipher preferences override on line 249.

• sslv3, pq-123,
• tls 1.0, pq-123,
• tls 1.1, pq-123
• tls 1.2, pq-123,
• tls 1.3, pq-123,

So each endpoint was queried 5 * 6 = 30 times, even though most queries were duplicates. After this change, each endpoints will only be queried 6 times.

I think that is still excessive, but this PR keeps coverage strictly the same, and only removes duplicated queries.

Testing:

Existing CI should pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[dougch]

Much faster, but I'm getting a noneType failure without this:

diff --git a/tests/integrationv2/utils.py b/tests/integrationv2/utils.py
index 3d7c20221..c96fb0d43 100644
--- a/tests/integrationv2/utils.py
+++ b/tests/integrationv2/utils.py
@@ -81,7 +81,7 @@ def invalid_test_parameters(*args, **kwargs):
             return True

     for provider_ in providers:
-        if not provider_.supports_protocol(protocol):
+        if protocol and not provider_.supports_protocol(protocol):
             return True

[jmayclin]

This is no longer relevant with the merging of #4884