-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor generate release notes script for enhanced release process #190
Refactor generate release notes script for enhanced release process #190
Conversation
7f6331d
to
81d9ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Perhaps we can include a main
function. It's a bit hard to trace through the code and might be more helpful in debugging. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (non-blocking): Could we also keep all of the functions grouped up for better readability? (i.e. get_ami_details
)
Thanks for your comment! That's reasonable, the main reason I had not included these were to follow the current convention / layout of the script and keep any such enhancements in scope of a separate pull request. However, upon second thought, it shouldn't take too much effort to include in scope of this PR defining a |
81d9ab8
to
354947b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Summary
Refactor generate release notes script (i.e.,
generate-release-notes.sh
) to fit with the enhanced release process being worked on in branchfeature/shinkansen
.NOTE: This pull request will be merged into branch
feature/shinkansen
.Implementation details
--exclude-ami
to specify what AMI variants are excluded in a given release, as with the enhanced release process any given AMI variant may not necessarily be includedmain
function and group commands living outside of a function into more granular functionsTesting
Manually pulled in the most recent release variables information from branch
main
and then tested:20231219
release using./generate-release-notes.sh --al2-gpu-nvidia-ver 535.129.03 --al2-gpu-cuda-ver 12.2.2 --al1-containerd-ver 1.4.13
command and comparing the generated release notes against the expected release notes usingdiff
. No differences were foundGenerated output
--exclude-ami
option/flag and confirming that the excluded AMI variants specified using that option are not included in the generated outputExample test
Input
Output
Example test
Input
Output
New tests cover the changes: no
Description for the changelog
Refactor generate release notes script for enhanced release process
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.