-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previous release vars #173
Merged
hozkaya2000
merged 1 commit into
aws:feature/shinkansen
from
hozkaya2000:feature/shinkansen
Dec 1, 2023
Merged
Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previous release vars #173
hozkaya2000
merged 1 commit into
aws:feature/shinkansen
from
hozkaya2000:feature/shinkansen
Dec 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hozkaya2000
force-pushed
the
feature/shinkansen
branch
2 times, most recently
from
November 30, 2023 18:21
a6756b0
to
f4ce9f3
Compare
…ainerd versions similar to previously existing release vars
hozkaya2000
force-pushed
the
feature/shinkansen
branch
from
November 30, 2023 18:36
f4ce9f3
to
8b1dcde
Compare
amogh09
approved these changes
Nov 30, 2023
yinyic
approved these changes
Dec 1, 2023
danehlim
pushed a commit
to danehlim/amazon-ecs-ami
that referenced
this pull request
Feb 6, 2024
…ainerd versions similar to previously existing release vars (aws#173)
danehlim
pushed a commit
to danehlim/amazon-ecs-ami
that referenced
this pull request
Feb 6, 2024
…ainerd versions similar to previously existing release vars (aws#173)
danehlim
added a commit
that referenced
this pull request
Feb 6, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (#165) * Change generate-release-vars.sh to update specific release files (#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (#178) * Remove unnecessary security update checks for al2023 (#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (aws#165) * Change generate-release-vars.sh to update specific release files (aws#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (aws#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (aws#178) * Remove unnecessary security update checks for al2023 (aws#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (aws#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
rwarren25
pushed a commit
to rwarren25/amazon-ecs-ami
that referenced
this pull request
Jul 9, 2024
* Add action to push to codecommit mirror ripository * release.auto.pkvars.hcl refactor: creating 1 file per AMI variant * Add script to check for security update of given ami (aws#165) * Change generate-release-vars.sh to update specific release files (aws#169) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars (aws#173) * Add generateConfig action, updates to check-update-security and generate-release-vars.sh (aws#174) * Modify generate-release-vars.sh to include ecs init, docker, and containerd versions similar to previously existing release vars * Add generateConfig action, small updates to check-update-security * Add security update install script in build recipe for al1 and al2 (aws#178) * Remove unnecessary security update checks for al2023 (aws#186) * Combine GenerateConfig and PushToCodeCommit actions under one action and add conditional kickoff (aws#187) * Refactor generate release notes script for enhanced release process --------- Co-authored-by: hozkaya2000 <[email protected]> Co-authored-by: Anuj Singh <[email protected]> Co-authored-by: hozkaya2000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the previous PRs for modifying generate-release-vars.sh and release files structure to change only specific AMIs release files, including information of dependency versions such as ECS Init, Docker, Containerd, ExecSSM was deemed useful in the release files. Therefore, the script has been updated to reflect this decision.
The reason including these dependencies are useful is to check whether any of these dependencies have been updated since the last release. Since the Agent Team will update the values of these dependencies in the variables.pkr.hcl file, the ./generate-release-vars.sh script will pull and update the release variables files. If there is a change in these dependencies from the previous release file, that means that the agent team has changed one of the dependency versions from last time, indicating the need for an update. The generate config action will pick up on this change and realize that a release is necessary, and kick it off.
Note that this script is modifying the template of the release-{ami_type}.auto.pkrvars.hcl files, since they were not modified to consider this use case before.
Implementation details
Add extraction of versions from the default values in the variables.pkr.hcl file, and use the extracted versions in the update of release-{ami_type}.auto.pkrvars.hcl file.
Testing
The script was run for each type of AMI locallly, successfully modifying each file as desired, and extracting the correct version from the variables.pkr.hcl file. The variables.pkr.hcl file was modified to exaggerate these differences and see them reflected at test time.
Other than that, here is the output of three test runs today:
Note that the version is automatically given as today, but these changes will NOT be pushed unless anything EXCEPT the ami_version has changed. This is implemented in the GenerateConfig Github Action.
New tests cover the changes: yes
Description for the changelog
Include ECS Init, Docker, and Containerd versions in release files for each AMI type.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.