Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ec2-instance-connect to AMI #166

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ec2-instance-connect to AMI #166

wants to merge 2 commits into from

Conversation

dali546
Copy link

@dali546 dali546 commented Nov 15, 2023

Summary

Include ec2-instance-connect to AL2023 AMI

Implementation details

Updated the default input variables

Testing

New tests cover the changes:

Description for the changelog

Add ec2-instance-connect package to AL2023 ECS AMI

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dali546
Copy link
Author

dali546 commented Nov 16, 2023

@singholt Hi, are you able to provide a review, or assist in getting this merged?

@dali546
Copy link
Author

dali546 commented Nov 21, 2023

@sparrc @chienhanlin Hi, is there any chance you could take a look at this PR?

@chienhanlin
Copy link
Contributor

Hello @dali546, thanks for reaching out to ECS.

As we have not supported this on ECS-optimized AL2023 AMIs, please create a feature request with more details in https://github.com/aws/amazon-ecs-ami/issues or https://github.com/aws/containers-roadmap/issues for us to work on this request. Thanks.

@chienhanlin chienhanlin added the enhancement New feature or request label Nov 22, 2023
@dali546
Copy link
Author

dali546 commented Nov 22, 2023

Hi @chienhanlin, I have created the issue below. Thank you

#170

@dali546
Copy link
Author

dali546 commented Nov 24, 2023

@chienhanlin There is an already existing issue here: aws/containers-roadmap#1300

variables.pkr.hcl Outdated Show resolved Hide resolved
@dali546
Copy link
Author

dali546 commented Dec 13, 2023

Hi @chienhanlin is there any update on this? I would very much like this to be baked in as installing it in userdata is flaky. sometimes the package fails to install, or hangs and never actually gets installed.
When used as part of an EC2 Autoscaling Group, it leads to misconfigured machines being provisioned

@dali546
Copy link
Author

dali546 commented Jan 9, 2024

@dali546
Copy link
Author

dali546 commented Feb 29, 2024

@chienhanlin can you please update myself on if this PR can be merged.

@dali546
Copy link
Author

dali546 commented Jun 24, 2024

@Yiyuanzzz @prateekchaudhry as recent contributors to this project, are you able to help push this through. It is a simple PR that will improve the workflow and connectivity of ECS AMIs

Include `ec2-instance-connect` to AL2023 AMI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants