-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ec2-instance-connect to AMI #166
base: main
Are you sure you want to change the base?
Conversation
@singholt Hi, are you able to provide a review, or assist in getting this merged? |
@sparrc @chienhanlin Hi, is there any chance you could take a look at this PR? |
Hello @dali546, thanks for reaching out to ECS. As we have not supported this on ECS-optimized AL2023 AMIs, please create a feature request with more details in https://github.com/aws/amazon-ecs-ami/issues or https://github.com/aws/containers-roadmap/issues for us to work on this request. Thanks. |
Hi @chienhanlin, I have created the issue below. Thank you |
@chienhanlin There is an already existing issue here: aws/containers-roadmap#1300 |
Hi @chienhanlin is there any update on this? I would very much like this to be baked in as installing it in userdata is flaky. sometimes the package fails to install, or hangs and never actually gets installed. |
7170cc5
to
fe3ee21
Compare
@chienhanlin can you please update myself on if this PR can be merged. |
@Yiyuanzzz @prateekchaudhry as recent contributors to this project, are you able to help push this through. It is a simple PR that will improve the workflow and connectivity of ECS AMIs |
Include `ec2-instance-connect` to AL2023 AMI
Summary
Include
ec2-instance-connect
to AL2023 AMIImplementation details
Updated the default input variables
Testing
New tests cover the changes:
Description for the changelog
Add ec2-instance-connect package to AL2023 ECS AMI
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.