-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading of AppNet Agent and capability publishing #3281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinyic
previously approved these changes
Jul 5, 2022
sparrc
reviewed
Jul 5, 2022
sparrc
reviewed
Jul 5, 2022
chienhanlin
reviewed
Jul 5, 2022
chienhanlin
reviewed
Jul 5, 2022
Realmonia
reviewed
Jul 5, 2022
yinyic
approved these changes
Jul 7, 2022
chienhanlin
approved these changes
Jul 7, 2022
yinyic
pushed a commit
to yinyic/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2022
* Add a container loader for AppNet Agent * Add the agent capability for ServiceConnect
yinyic
pushed a commit
to yinyic/amazon-ecs-agent
that referenced
this pull request
Oct 3, 2022
* Add a container loader for AppNet Agent * Add the agent capability for ServiceConnect
yinyic
pushed a commit
to yinyic/amazon-ecs-agent
that referenced
this pull request
Oct 3, 2022
* Add a container loader for AppNet Agent * Add the agent capability for ServiceConnect
ubhattacharjya
pushed a commit
that referenced
this pull request
Oct 4, 2022
* Add a container loader for AppNet Agent * Add the agent capability for ServiceConnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the required capability for ECS Agent to publish if it has the AppNet Agent image available.
Implementation details
Loads the managed container from disk and publishes the capability on success.
Testing
Validated that image is properly loaded from tarfile.
Tested capability publishing end to end and validated that new capability was published.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.