Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSQL: relational migration merge - guide #121

Merged
merged 14 commits into from
Nov 16, 2024
Merged

LSQL: relational migration merge - guide #121

merged 14 commits into from
Nov 16, 2024

Conversation

robm26
Copy link
Contributor

@robm26 robm26 commented Nov 13, 2024

Instructions for the new relational-migration workshop

Several readme files and static images. No code since this is retrieved by the user with git clone from another repository. Thank you!!!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@switch180 switch180 changed the title relational migration instructions initial LSQL: relational migration merge - guide Nov 13, 2024
@switch180
Copy link
Contributor

Requested changes:

  1. Use a Parameter for the MySQL password and username instead of hard coding it. Follow the method seen here. Parameter at the top of the stack, referenced in the user data script
  2. Pre-cache the code for the workshop on the C9 instance instead of having a git clone. UserData script. We will talk about this.
  3. Provide the license for vehicles.png so we know we have the permission to use it on our lab
  4. Update the main index.en.md to explain what technologies you will use. You should list them all out, with a separate section for AWS services and code frameworks.
  5. Complete your changes by Friday :-)

Copy link
Contributor

@switch180 switch180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback added on C9.yaml - please address the line comments

design-patterns/cloudformation/C9.yaml Outdated Show resolved Hide resolved
design-patterns/cloudformation/C9.yaml Outdated Show resolved Hide resolved
design-patterns/cloudformation/C9.yaml Outdated Show resolved Hide resolved
design-patterns/cloudformation/C9.yaml Outdated Show resolved Hide resolved
design-patterns/cloudformation/C9.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@switch180 switch180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix list:

  • Add level to introduction of lab, and say whether this can be done on your own or at an aws event. explain if it has any accompanying material such as a pptx that are unavaible to the student. and add hyperlink to folder where the code exists in the other repo
  • add a "on your own" and "at an aws event" setup
  • setenv has hard coded password and username but should get values from CFN somehow
  • Migrate this to the AWS DynamoDB Labs AWS account https://dynamodbworkshop.s3.amazonaws.com/migration/index.html
  • Hard coded region in https://github.com/aws-samples/aws-dynamodb-examples/blob/master/workshops/relational-migration/migrate.sh
  • content/relational-migration/summary/index.en.md add a hyperlink to your workshop source code for DIY migrations
  • add required release to code samples that customers may use in production (AWS policy)
  • remove hard coded AWS_DEFAULT_REGION in setenv.sh
  • Hard code final commit version for aws-dynamodb-examples

Post launch checklist

  • Review dataset and ensure we are using approved data

content/relational-migration/index.en.md Outdated Show resolved Hide resolved
content/relational-migration/introduction/index.en.md Outdated Show resolved Hide resolved
content/relational-migration/introduction/index.en.md Outdated Show resolved Hide resolved
static/images/relational-migration/phases.png Outdated Show resolved Hide resolved
static/images/relational-migration/import.png Outdated Show resolved Hide resolved
static/images/relational-migration/relational_schema.png Outdated Show resolved Hide resolved
@switch180
Copy link
Contributor

Patching userdata in #122

@switch180
Copy link
Contributor

switch180 commented Nov 15, 2024

Pulling up todos from some of the line items for later follow up:

  • Share MySQL WB file for this ERD [static/images/relational-migration/relational_schema.png]
  • content/relational-migration/data migration/index3.en.md add image to step 6 to show import from s3

@switch180 switch180 merged commit ba4946e into master Nov 16, 2024
1 check passed
@switch180 switch180 deleted the migration branch November 16, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants