-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSQL: relational migration merge - guide #121
Conversation
Requested changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback added on C9.yaml - please address the line comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix list:
- Add level to introduction of lab, and say whether this can be done on your own or at an aws event. explain if it has any accompanying material such as a pptx that are unavaible to the student. and add hyperlink to folder where the code exists in the other repo
- add a "on your own" and "at an aws event" setup
- setenv has hard coded password and username but should get values from CFN somehow
- Migrate this to the AWS DynamoDB Labs AWS account https://dynamodbworkshop.s3.amazonaws.com/migration/index.html
- Hard coded region in https://github.com/aws-samples/aws-dynamodb-examples/blob/master/workshops/relational-migration/migrate.sh
- content/relational-migration/summary/index.en.md add a hyperlink to your workshop source code for DIY migrations
- add required release to code samples that customers may use in production (AWS policy)
- remove hard coded AWS_DEFAULT_REGION in setenv.sh
- Hard code final commit version for aws-dynamodb-examples
Post launch checklist
- Review dataset and ensure we are using approved data
content/relational-migration/application refactoring/index3.en.md
Outdated
Show resolved
Hide resolved
content/relational-migration/application refactoring/index3.en.md
Outdated
Show resolved
Hide resolved
Patching userdata in #122 |
Pulling up todos from some of the line items for later follow up:
|
Instructions for the new relational-migration workshop
Several readme files and static images. No code since this is retrieved by the user with git clone from another repository. Thank you!!!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.