-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigParser: Removed py2 support #4020
Conversation
993345b
to
6aa1364
Compare
@bskjois Please fix the static checks issue. The changes look great to me. |
3f6351e
to
f4261ba
Compare
@xiaodwan I used "isort" command and executed against all 7 files. WIth that I faced static failures(Here it is: https://github.com/avocado-framework/avocado-vt/actions/runs/11593886597/job/32278881855?pr=4020) So, I have corrected all the errors shown there. Also, I have sorted the imports accordingly. Still 1 check is failing. Please take a look. Even with the current failure, it is showing 6/7 files have Imports which are incorrectly sorted. But isort command itself is not showing anything for most of them. Also Imports are sorted and is clearly visible. Please take a review. If in case required, I have allowed edits by maintainers too! |
03568b7
to
0a904bb
Compare
Hi @bskjois |
Thank you @chloerh I had tried that command earlier too! But it says "unrecognized arguments: --profile" Even in isort commad's usage, I don't see profile. Looks like it has been removed or so. Could you please confirm.
|
Signed-off-by: Kowshik Jois B S <[email protected]>
0a904bb
to
cdf80c8
Compare
@chloerh I understood what was missing. Instead of using the isort command downloaded via pip3, I was using the one which was downloaded with dnf. Now I used the pip3 one and all the checks are successful. |
Signed-off-by: Kowshik Jois B S [email protected]