RFC: Switch build backend to hatchling and use pyproject.toml #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulYuuu
changed the title
PaulYuuu
force-pushed
the
pyproject
branch
6 times, most recently
from
cef6d5e
to
2084547
Compare
PaulYuuu
changed the title
PaulYuuu
force-pushed
the
pyproject
branch
3 times, most recently
from
60f8949
to
c0dd58a
Compare
|
Hello @luckyh @clebergnu @richtja, as I can see directly invoke @clebergnu I also saw the avocado issue avocado-framework/avocado#5754, as VT is a plugin of avocado, so I am happy to listen to your voice, not sure what's the plan for avocado. I also tried to migrate avocado to hatch, but the setup.py has some complex custom targets, so I only modified some basic settings. |
PaulYuuu
force-pushed
the
pyproject
branch
4 times, most recently
from
b99746d
to
eafc079
Compare
Modernize a setup.py based project by adding pyproject.toml, move package configuration to pyproject.toml, and use hatchling as the builder instead of setuptools. Refs: https://packaging.python.org/en/latest/guides/modernize-setup-py-project Refs: https://hatch.pypa.io/latest/why Signed-off-by: Yihuang Yu <[email protected]>
Config file of black, isort and pylint can be pyproject.toml, so add some basic settings in pyproject.toml, so users can use the simple command to format. Signed-off-by: Yihuang Yu <[email protected]>
VT currently supports from python3.8, but centos 8 uses python3.6, so remove it. Signed-off-by: Yihuang Yu <[email protected]>
Migrate deprecated "setup.py install/develop" with "pip install", also some "setup.py build" to "python -m build". For the custom clean target, convert it to shell in the Makefile. Also use the hatch cli as the entry to run formatter and linter. Refs: https://packaging.python.org/en/latest/discussions/setup-py-deprecated Signed-off-by: Yihuang Yu <[email protected]>
egg had been replaced with wheel format, and should not be used anymore. Refs: https://packaging.python.org/en/latest/discussions/package-formats/#what-about-eggs Signed-off-by: Yihuang Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize a setup.py based project by adding pyproject.toml, move
package configuration to pyproject.toml, and also switch to hatchling as the build backend.
Refs: https://packaging.python.org/en/latest/guides/modernize-setup-py-project
Signed-off-by: Yihuang Yu [email protected]