Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update distro #46

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ci: update distro #46

merged 1 commit into from
Jun 21, 2024

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 28, 2024

  • update distros in ci

Signed-off-by: wep21 <[email protected]>
@wep21 wep21 requested a review from xmfcx April 28, 2024 03:42
@wep21 wep21 marked this pull request as draft April 28, 2024 03:43
@wep21 wep21 marked this pull request as ready for review April 29, 2024 15:25
@Scout22
Copy link

Scout22 commented Jun 21, 2024

@xmfcx when do you think you could accept this edit.
We are reliant on socketcan and this is currently blocking our transition to ROS2 jazzy

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@xmfcx xmfcx merged commit 3c82371 into main Jun 21, 2024
6 checks passed
@xmfcx xmfcx deleted the update-ci branch June 21, 2024 22:54
@wep21
Copy link
Contributor Author

wep21 commented Jun 22, 2024

@xmfcx please create a new tag and do bloom-release for jazzy and rolling because it still fails.
https://build.ros2.org/job/Rbin_uN64__ros2_socketcan__ubuntu_noble_amd64__binary/

@xmfcx
Copy link
Contributor

xmfcx commented Jun 22, 2024

@wep21 I don't know how this repository is connected to the ROS build farm.

And I've never done a bloom-release before. (Where do you do that?)

I've also found this: https://github.com/ros2-gbp/ros2_socketcan-release/ that has commits from you (without any pull requests) and I also don't have access to that repository as well.

What should I do?

I've created this https://github.com/autowarefoundation/ros2_socketcan/releases/tag/1.3.0 tag if it is going to be useful.

@xmfcx
Copy link
Contributor

xmfcx commented Jun 22, 2024

I think I should also add myself to the release team like you added @mitsudome-r to your place here:

@JWhitleyWork
Copy link
Collaborator

@xmfcx Hey, old friend. Here is the basic connection/process for release:

This repository is not directly connected to the build farm. However, https://github.com/ros2-gbp/ros2_socketcan-release/ is and it contains branches with copies of this repository at specific timepoints/tags. In order to release a new version of this repository for a specific version of ROS2, you must do the following:

  1. Install python3-catkin-pkg and python3-bloom from the ROS2 apt repo.
  2. In this repository, on the branch you intend to release, run catkin_generate_changelog.
  3. Clean up and update the contents of the CHANGELOG.rst file for each package in the repo. By default, they will contain the commit messages of all commits since the last release.
  4. Commit and push the updated changelogs.
  5. In this repository, on the branch you intend to release, run catkin_prepare_release. By default this will bump the release by a major version - you can change this with the --bump argument. This will update the version in package.xml and tag the current commit with the new version.
  6. Run bloom-release --track <ros2_distro> --ros-distro <ros2_distro> ros2_socketcan. Since release tracks have already been set up for this repository for the currently-available ROS2 distros and because the tracks are already configured to point to this repository and the main branch to look for tags, it will automatically find the new release tag, create a bunch of branches on https://github.com/ros2-gbp/ros2_socketcan-release/, and then create a Pull Request on https://github.com/ros/rosdistro which will update the information in the distribution.yaml file for the selected ROS2 distro which rosdep uses to let the build farm know about the latest available release for a given package.

If you are updating releases for multiple ROS2 distros based on the same, new release on this repo, you only need to run the bloom-release step for each ROS2 distro.

Here is the source of most of this information (but in a more confusing layout): https://wiki.ros.org/bloom/Tutorials/FirstTimeRelease

Hit me up if you have any questions.

@g-arjones
Copy link

Any plans to release this on Jazzy? Thanks!

@xmfcx
Copy link
Contributor

xmfcx commented Jul 16, 2024

Oh no I completely forgot about this, Thanks @JWhitleyWork for the detailed explanation. Now that I'm a part of the release team, I will follow your instructions to release this for jazzy.

Sorry everyone for looking over this 🙇‍♂️

@g-arjones
Copy link

Thanks!

@xmfcx xmfcx mentioned this pull request Jul 16, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jul 16, 2024

@wep21 @JWhitleyWork @g-arjones @Scout22
I hope I did things correctly, here is the list of PRs to the releases:

Thank you for your patience.

@g-arjones
Copy link

It looks like you did: https://repo.ros2.org/status_page/ros_jazzy_default.html?q=ros2_socketcan

We just have to wait for a sync now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants