Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from yarn to bun #14

Closed
wants to merge 14 commits into from
Closed

Conversation

marc-aurele-besner
Copy link
Collaborator

Switch from yarn to bun

Yarn is a bit of a pain, the traditional yarn does not support import path such as workspace:*.
So I had first switched to yarn berry (canary -> 4.2.5) but it seems to be very inconsistent with there lock file, now using both yarn.lock and a couple .pnp files 🤯

And this seems to cause some weird incompatibility with vscode, as prettier on save and vs code does not detect the dependencies as installed anymore...

I tested bun last night, and it seems to work as we need-it out of the box and be faster

@marc-aurele-besner marc-aurele-besner linked an issue Jun 5, 2024 that may be closed by this pull request
abhi3700
abhi3700 previously approved these changes Jun 5, 2024
Copy link
Contributor

@abhi3700 abhi3700 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfrank-summit
Copy link
Member

@marc-aurele-besner I haven't used Bun but have heard some positive things about it. Are there any risks associated with a switch?

@marc-aurele-besner
Copy link
Collaborator Author

@marc-aurele-besner I haven't used Bun but have heard some positive things about it. Are there any risks associated with a switch?

That early on in the project, not really, the switch will have been a bit more painful if we had a super developed and complex mono repo.

The end user is still free to use Bun, Yarn, or NPM when integrating the packages. It's primarily for development and contribution that it matter.
Unlike a switch to Deno for example that make things, not backward compatible.

jfrank-summit
jfrank-summit previously approved these changes Jun 5, 2024
@marc-aurele-besner marc-aurele-besner marked this pull request as draft June 5, 2024 21:39
@marc-aurele-besner
Copy link
Collaborator Author

After syncing with main, following #9 we have some issues that I can't solve.
Atm, I guess that some of the node:crypto implementations in Bun are either missing or not the same as on Node...
auto-id tests result with Bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from yarn to bun
3 participants