Add support for rendering the settings of prompt-screen #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Include unit tests, examples and docs 3. Update Go-Auth0's dependent version
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
It would be better to use as an enum as the values are not constant
| StateContext: schema.ImportStatePassthroughContext, | ||
| }, | ||
| Description: "With this resource, you can Configure the render settings for a specific screen." + | ||
| "You can read more about this [here](https://auth0.com/docs/customize/universal-login-pages/.../acul).", |
| Computed: true, | ||
| ValidateFunc: validation.StringIsJSON, | ||
| DiffSuppressFunc: structure.SuppressJsonDiff, | ||
| Description: "An array of head tags", |
There was a problem hiding this comment.
please add better description
| func deletePromptScreenRenderer(ctx context.Context, data *schema.ResourceData, meta any) diag.Diagnostics { | ||
| api := meta.(*config.Config).GetAPI() | ||
| idComponents := strings.Split(data.Id(), ":") | ||
| promptName, screenName := idComponents[0], idComponents[1] |
There was a problem hiding this comment.
please add check and validation promptName, screenName
|
|
||
| func readPromptScreenRenderer(ctx context.Context, data *schema.ResourceData, meta any) diag.Diagnostics { | ||
| api := meta.(*config.Config).GetAPI() | ||
| promptScreenSettings, err := api.Prompt.ReadRendering(ctx, management.PromptType(strings.Split(data.Id(), ":")[0]), management.ScreenName(strings.Split(data.Id(), ":")[1])) |
There was a problem hiding this comment.
Please add check and validation for [0] and [1] in case invalid
| return diag.FromErr(internalError.HandleAPIError(data, err)) | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
should not it call readPromptScreenRenderer() instead for return null?
|
|
||
| const ( | ||
| testAccPromptScreenRenderWithoutSettings = ` | ||
| resource "auth0_prompt_screen_renderer" "prompt_screen_renderer" { |
There was a problem hiding this comment.
please add cases for:
resource "auth0_prompt_screen_renderer" "prompt_screen_renderer" {
screen_name = "logout"
}
resource "auth0_prompt_screen_renderer" "prompt_screen_renderer" {
prompt_type = "logout"
}
| ), | ||
| }, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
please add case for testAccPromptScreenRenderDelete
|
|
||
| # Resource: auth0_prompt_screen_renderer | ||
|
|
||
| With this resource, you can Configure the render settings for a specific screen.You can read more about this [here](https://auth0.com/docs/customize/universal-login-pages/.../acul). |
|
e2e test recordings are not available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Added new resources and data sources: "auth0_prompt_screen_renderer"
Added relevant expand and flatten rules.
Added relevant test cases for data_source and resource.
Added relevant docs and examples.
Example
📝 Checklist