Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof of concept for using the keyof operator instead of a function parser #486

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proof of concept for using the keyof operator instead of a function parser #486

wants to merge 3 commits into from

Commits on Apr 20, 2018

  1. feat(PropertyAccessorParser): Remove PropertyAccessorParser in favor of 

    the keyof operator.

Calls to .ensure() allowed both a string and a function as argument. The
function was never actually executed, but parsed to get the string
property name. The same effect can be achieved by using the keyof
operator. In this case, only strings can be provided that are a property
of the given class.

Initial version, requiring the programmer to explicitly state the object
class each time .ensure() is executed. This is because .ensure() is a
static function, so the type cannot be determined yet.

Fixes aurelia#485.
    TimVevida committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    87ae8bc View commit details
    Browse the repository at this point in the history

  2. feat(PropertyAccessorParser): Remove PropertyAccessorParser in favor of 

    the keyof operator.

Calls to .ensure() allowed both a string and a function as argument. The
function was never actually executed, but parsed to get the string
property name. The same effect can be achieved by using the keyof
operator. In this case, only strings can be provided that are a property
of the given class.

Initial version, requiring the programmer to explicitly state the object
class each time .ensure() is executed. This is because .ensure() is a
static function, so the type cannot be determined yet.

Fixes aurelia#485.
    TimVevida committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    3f58942 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/TimVevida/validation

    TimVevida committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    365d9c3 View commit details
    Browse the repository at this point in the history