-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build ux #229
Fix build ux #229
Conversation
Will this close also #162 ? |
Yes, it will. Im working some fixes locally, will push soon |
@EisenbergEffect @ben-girardet I think i've finished it, this PR fixes html build issues, and will also fixes CSS bundling issue (atm, it's not giving any hints to webpack to bundle css, oops) |
@bigopon Will this all continue to work correctly is someone is using the CLI bundler instead of Webpack? |
I think so, because cli bundler does not have issue with module reference like webpack. Im using 2nd parameter of |
@@ -1,12 +1,17 @@ | |||
{ | |||
"extends": "../tsconfig.json", | |||
"compilerOptions": { | |||
"target": "esnext", | |||
"esModuleInterop": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct choice :-)
@@ -1,12 +1,17 @@ | |||
{ | |||
"extends": "../tsconfig.json", | |||
"compilerOptions": { | |||
"target": "esnext", | |||
"esModuleInterop": true, | |||
"allowSyntheticDefaultImports": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is by default turned on when esModuleInterop is true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, will clean this up
@EisenbergEffect it's ready to go. All builds have been reverted to multi-modules with modules referenced by strings. Also adjusted example app to ensure we can still develop with source code aliasing instead of having to build. @ben-girardet and huge thanks to @3cp for the links and reminder |
thanks @bigopon looking forward to continue working on this lib. |
The type declaration in
html.d.ts
is different with what emitted by rollup html plugin (default es export). Tweak the types / import to align to the rollup plugin. Also fix the example app to adapt this changecloses #228