Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build ux #229

Merged
merged 27 commits into from
Dec 3, 2019
Merged

Fix build ux #229

merged 27 commits into from
Dec 3, 2019

Conversation

bigopon
Copy link
Member

@bigopon bigopon commented Nov 23, 2019

The type declaration in html.d.ts is different with what emitted by rollup html plugin (default es export). Tweak the types / import to align to the rollup plugin. Also fix the example app to adapt this change

closes #228

@ben-girardet
Copy link
Contributor

Will this close also #162 ?

@bigopon
Copy link
Member Author

bigopon commented Nov 24, 2019

Yes, it will. Im working some fixes locally, will push soon

@bigopon
Copy link
Member Author

bigopon commented Nov 25, 2019

@EisenbergEffect @ben-girardet I think i've finished it, this PR fixes html build issues, and will also fixes CSS bundling issue (atm, it's not giving any hints to webpack to bundle css, oops)

@EisenbergEffect
Copy link
Contributor

@bigopon Will this all continue to work correctly is someone is using the CLI bundler instead of Webpack?

@bigopon
Copy link
Member Author

bigopon commented Nov 25, 2019

I think so, because cli bundler does not have issue with module reference like webpack. Im using 2nd parameter of @inlineView decorator to add resources to a view. I think this is understood by the cli bundler, cc @3cp

@EisenbergEffect
Copy link
Contributor

If we can get @3cp to do a quick review as well just in case, that would make me feel more comfortable. Thanks for putting the work in @bigopon

@@ -1,12 +1,17 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"target": "esnext",
"esModuleInterop": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct choice :-)

@@ -1,12 +1,17 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"target": "esnext",
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by default turned on when esModuleInterop is true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will clean this up

@bigopon
Copy link
Member Author

bigopon commented Dec 2, 2019

@EisenbergEffect it's ready to go. All builds have been reverted to multi-modules with modules referenced by strings. Also adjusted example app to ensure we can still develop with source code aliasing instead of having to build. @ben-girardet

and huge thanks to @3cp for the links and reminder

@ben-girardet
Copy link
Contributor

thanks @bigopon looking forward to continue working on this lib.

@EisenbergEffect EisenbergEffect merged commit 64ec9bb into aurelia:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot convert object to primitive value with 0.17.0
4 participants