fix(route-href): prefix the pathname for fragment hrefs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat841
force-pushed
the
feature/route-href-fix
branch
3 times, most recently
from
bee7fde
to
b0d1179
Compare
pat841
force-pushed
the
feature/route-href-fix
branch
from
b0d1179
to
b0953f2
Compare
|
Would you mind taking a look @EisenbergEffect |
|
@davismj is our router lead. Matt, any thoughts on this? |
davismj
reviewed
Oct 25, 2018
| @@ -47,6 +47,11 @@ export class RouteHref { | |||
|
|
|||
| let href = this.router.generate(this.route, this.params); | |||
|
|
|||
| // Ensure fragments are created correctly | |||
| if (href.startsWith('#') && window.location) { | |||
There was a problem hiding this comment.
Unfortunately, this approach will not make it in. Though in your case it does probably fix the issue, there are two key problems. First, and most importantly, we don't and can't depend on the window object as this can be run in node in a SSR scenario. Second, this code should be relegated to the this.router.generate function.
davismj
requested changes
Oct 25, 2018
There was a problem hiding this comment.
This is likely related to aurelia/router#451 or aurelia/router#252.
A PR that resolves this issue must:
- not depend on window, use the router.baseUrl instead
- have a consistent behavior with or without pushState
- have a consistent behavior with or without query parameters
- contain tests that verify the behavior works in both of the above scenarios for various urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems when a
<base>tag is used and a url contains something likeindex.html?some=querythen theroute-hrefsets an incorrecthreflink.To reproduce:
http://run.plnkr.co/preview/<ID>/index.html?testing=trueurl that is printed in a new tab.NEXT PAGEand see the page force refresh back to#/next-pagethen back toindex.html?testing=true#/homeThis fix adds the windows pathname and search query before the href fragment so that it does not force a new page load.