Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dns feature #181

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add dns feature #181

wants to merge 9 commits into from

Conversation

atkrad
Copy link
Owner

@atkrad atkrad commented May 16, 2023

No description provided.

@mortymacs mortymacs changed the title WIP: Add dns feature Add dns feature Jun 3, 2023
@coveralls
Copy link

coveralls commented Jun 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 10594112795

Details

  • 243 of 274 (88.69%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.7%) to 69.171%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/wait4x/cmd/root.go 0 1 0.0%
checker/dns/a/a.go 40 45 88.89%
checker/dns/aaaa/aaaa.go 40 45 88.89%
checker/dns/cname/cname.go 40 45 88.89%
checker/dns/mx/mx.go 41 46 89.13%
checker/dns/ns/ns.go 41 46 89.13%
checker/dns/txt/txt.go 41 46 89.13%
Totals Coverage Status
Change from base Build 10592834920: 4.7%
Covered Lines: 976
Relevant Lines: 1411
💛 - Coveralls

@mortymacs
Copy link
Collaborator

The PR is ready 😉

@atkrad atkrad self-assigned this Jun 3, 2023
atkrad
atkrad commented Jun 3, 2023
View reviewed changes
checker/dns/a/a.go Outdated Show resolved Hide resolved
checker/dns/a/a.go Outdated Show resolved Hide resolved
checker/dns/aaaa/aaaa.go Outdated Show resolved Hide resolved
checker/dns/cname/cname.go Outdated Show resolved Hide resolved
checker/dns/mx/mx.go Show resolved Hide resolved
checker/dns/aaaa/aaaa_test.go Show resolved Hide resolved
checker/dns/cname/cname_test.go Show resolved Hide resolved
checker/dns/mx/mx_test.go Show resolved Hide resolved
checker/dns/ns/ns_test.go Show resolved Hide resolved
checker/dns/txt/txt_test.go Show resolved Hide resolved
atkrad
atkrad commented Jun 3, 2023
View reviewed changes
internal/app/wait4x/cmd/dns/aaaa.go Outdated Show resolved Hide resolved
internal/app/wait4x/cmd/dns/a.go Outdated Show resolved Hide resolved
@atkrad atkrad added the feature New feature or request label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortymacs mortymacs mortymacs left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@atkrad atkrad

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atkrad @coveralls @mortymacs