Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customized IP address hosting, executable file for 2 platforms, pycharm ide support, windows escape sequence correction #60

Closed
wants to merge 9 commits into from

Conversation

amaank404
Copy link
Contributor

@amaank404 amaank404 commented Sep 30, 2020

I have added the new option -i or --server-ip. By using this option a person can configure the hosting IP. This is required because most developers need that feature. Your project might not be good enough without it.

Also, I have added:

  • Support for editing project with Pycharm IDE.
  • Windows Executable for the project
  • Windows Support for colored console
  • Linux Executable for the project

fixes: #59
fixes: #61
fixes: #56
fixes: #57

@amaank404 amaank404 marked this pull request as draft September 30, 2020 09:21
@amaank404 amaank404 marked this pull request as ready for review September 30, 2020 10:30
@amaank404 amaank404 changed the title Support for customized IP address hosting customized IP address hosting, executable file for 2 platforms, pycharm ide support, windows escape sequence correction Sep 30, 2020
@gridhead gridhead self-requested a review October 2, 2020 03:17
@gridhead
Copy link
Member

gridhead commented Oct 2, 2020

I have added the new option -i or --server-ip. By using this option a person can configure the hosting IP. This is required because most developers need that feature. Your project might not be good enough without it.

Please list the issue that you are addressing with the pull request.

fixes: #59
fixes: #61
fixes: #56
fixes: #57

Unfortunately, we follow a one-pull-request-per-issue policy here. I would now have to tag this pull request invalid as it would not be of much help.

@gridhead gridhead added the invalid This doesn't seem right label Oct 2, 2020
Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are directed to get assigned to an issue first and then make one pull request against one issue. Thank you for taking the time to contribute to this project.

@amaank404
Copy link
Contributor Author

well no problem

@amaank404 amaank404 closed this Oct 2, 2020
@amaank404 amaank404 removed their assignment Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
2 participants