Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mpariente 🐿️
I tried to fix the continuous integration before doing a new release (as mentioned in #664).
It should work 🤞 But I have a couple of questions:
master
intoci_fix
branch. Should I have forked the repo a second time before doing my new commits? Or rebase my development branch as proposed here?scipy.signal.get_window(window="hanning")
is not supported in newer version of scipy and is replaced bywindow="hann"
(check documentation v0.11.0 vs v1.11.1). I didn't succeed to install a version ofscipy
which works withwindow="hanning"
and is compatible with the others libraries installed in the requirements. So instead, I replacedhanning
byhann
in the arguments and changed the requirements toscipy>=1.10.1
(which works on my computer). I feel like it is not the best solution aswindow="hanning"
was working before, should I change this fix?Thanks!